TO-51: API supports reviewers in environments#599
Merged
almeidaraul merged 21 commits intomainfrom Mar 17, 2026
Merged
Conversation
…iewer from the list)
…iling because feature is not implemented yet)
…ironments for an artefact
Base automatically changed from
TO-51/add-reviewer-list-to-environments
to
main
March 13, 2026 15:21
There was a problem hiding this comment.
Pull request overview
Adds API support for environment review “reviewers” by extending the environment-reviews response schema and ensuring the relevant relationships are eagerly loaded so reviewer data is returned consistently.
Changes:
- Extend
ArtefactBuildEnvironmentReviewResponseto include areviewersfield and add a dedicated reviewer response model. - Eager-load
ArtefactBuildEnvironmentReview.reviewersin the GET and single-review PATCH endpoints. - Update/extend controller tests and OpenAPI schema to reflect the new
reviewersfield.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/tests/data_generator.py | Allows generating environment reviews with attached reviewers for tests. |
| backend/tests/controllers/artefacts/test_environment_reviews.py | Updates expected payloads to include reviewers and adds new reviewer-focused tests. |
| backend/test_observer/controllers/artefacts/models.py | Adds reviewer response schema and includes reviewers in environment review response model. |
| backend/test_observer/controllers/artefacts/environment_reviews.py | Ensures reviewers are eagerly loaded for GET and single-review PATCH responses. |
| backend/schemata/openapi.json | Updates OpenAPI components to document the new reviewer schema and field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
rpbritton
approved these changes
Mar 17, 2026
Collaborator
rpbritton
left a comment
rpbritton
left a comment
There was a problem hiding this comment.
LGTM!
(also please use the PR template)
Contributor
Author
|
done @rpbritton |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added API support to reviewers in environments, i.e., change endpoints to reflect those changes in previous PRs
Resolved issues
Part of TO-291
Web service API changes
Changed endpoints for environments