Skip to content

[TO-340] Enable copy link#691

Merged
rpbritton merged 5 commits intomainfrom
TO-340/enable-copy-link
Apr 6, 2026
Merged

[TO-340] Enable copy link#691
rpbritton merged 5 commits intomainfrom
TO-340/enable-copy-link

Conversation

@rpbritton
Copy link
Copy Markdown
Collaborator

@rpbritton rpbritton commented Apr 6, 2026

Description

Uses the native Link widget to enable right-click copy link and makes the link text select-able

Resolved issues

Fixes #667

Documentation

N/A

Web service API changes

N/A

Tests

See the following screenshots:

Screenshot from 2026-04-06 08-03-55 Screenshot from 2026-04-06 08-05-18

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Flutter frontend’s inline URL rendering to use url_launcher’s Link widget, aiming to make links behave more like real hyperlinks (e.g., enabling “copy link” via browser context menu).

Changes:

  • Replace TapGestureRecognizer + launchUrlString with Link from package:url_launcher/link.dart.
  • Refactor InlineUrlText to build a reusable linkWidget and embed it into RichText when leading/trailing text is present.

Comment thread frontend/lib/ui/inline_url_text.dart Outdated
Copilot AI review requested due to automatic review settings April 6, 2026 14:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread frontend/lib/ui/inline_url_text.dart Outdated
Comment thread frontend/lib/ui/navigable_link.dart
Comment thread frontend/lib/ui/navigable_link.dart Outdated
Comment thread frontend/lib/ui/navigable_link.dart Outdated
Comment thread frontend/lib/ui/navigable_link.dart Outdated
@mclemenceau
Copy link
Copy Markdown
Collaborator

Hey @rpbritton, Thanks for this alternative to #683 . So I'm able to right click on the link and copy the URL which is definitely a plus. Now I'm not able to select the text like your screenshots earlier. When I try to select the text, it tries to move the link rather than select the text. see screenshot.

image

How did you do the text highlight ?

@rpbritton
Copy link
Copy Markdown
Collaborator Author

Hey @rpbritton, Thanks for this alternative to #683 . So I'm able to right click on the link and copy the URL which is definitely a plus. Now I'm not able to select the text like your screenshots earlier. When I try to select the text, it tries to move the link rather than select the text. see screenshot.
image

How did you do the text highlight ?

You sort of have to start selecting near, like start from "image link". Maybe editing the style of the image link to look more like a hyperlink would be clearer, and maybe "image link" should also be selectable.

@mclemenceau
Copy link
Copy Markdown
Collaborator

@rpbritton Ack, Ok I was able to select the text, it is a bit tricky but doable. The rick click to save the link is definitely an improvement. I'll likely approve this PR based on User Experience. but I also recommend you review my PR #683 as it offer both text selection and a intuitive download link. It is also fairly limited in scope to the artifact detail view. Thanks

Copy link
Copy Markdown
Collaborator

@mclemenceau mclemenceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that branch in confirmed Link Copy is working, Nice quality of life improvement.

@rpbritton rpbritton merged commit f905121 into main Apr 6, 2026
7 checks passed
@rpbritton rpbritton deleted the TO-340/enable-copy-link branch April 6, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download link not selectable, no option to get it into clipboard.

3 participants