Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Flutter frontend’s inline URL rendering to use url_launcher’s Link widget, aiming to make links behave more like real hyperlinks (e.g., enabling “copy link” via browser context menu).
Changes:
- Replace
TapGestureRecognizer + launchUrlStringwithLinkfrompackage:url_launcher/link.dart. - Refactor
InlineUrlTextto build a reusablelinkWidgetand embed it intoRichTextwhen leading/trailing text is present.
|
Hey @rpbritton, Thanks for this alternative to #683 . So I'm able to right click on the link and copy the URL which is definitely a plus. Now I'm not able to select the text like your screenshots earlier. When I try to select the text, it tries to move the link rather than select the text. see screenshot.
How did you do the text highlight ? |
You sort of have to start selecting near, like start from "image link". Maybe editing the style of the image link to look more like a hyperlink would be clearer, and maybe "image link" should also be selectable. |
|
@rpbritton Ack, Ok I was able to select the text, it is a bit tricky but doable. The rick click to save the link is definitely an improvement. I'll likely approve this PR based on User Experience. but I also recommend you review my PR #683 as it offer both text selection and a intuitive download link. It is also fairly limited in scope to the artifact detail view. Thanks |
mclemenceau
left a comment
There was a problem hiding this comment.
Tested that branch in confirmed Link Copy is working, Nice quality of life improvement.


Description
Uses the native
Linkwidget to enable right-click copy link and makes the link text select-ableResolved issues
Fixes #667
Documentation
N/A
Web service API changes
N/A
Tests
See the following screenshots: