fix(submit): allow submit to be called by nested composite actions#1014
Merged
rene-oromtz merged 2 commits intomainfrom Apr 15, 2026
Merged
fix(submit): allow submit to be called by nested composite actions#1014rene-oromtz merged 2 commits intomainfrom
rene-oromtz merged 2 commits intomainfrom
Conversation
ajzobro
previously approved these changes
Apr 15, 2026
Collaborator
|
Looks good to me, not sure if my understanding of the comment is right though. |
Contributor
Author
|
@ajzobro thanks for the review! I just pushed your suggestions regarding the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current
github_refthat is used so thetestflinger-setuphas the same reference as the submit action and it work in almost all but one edge case.Whenever calling the submit action from another composite action in "Repo B" which is then called from a third repo called "Repo C" and using a specified hash or tag, it will not honor the revision from which the submit action is called e.g.
repoC: uses
actionB@my-branchrepoB:
actionBusessubmit@submit/v1.4.4The
github_refwill then be set tomy-branchwhich does not exist in this repository causing a failure.To enable developers to test local changes on composite action, this PR changes to
github.action_pathto create a local copy of thetestflinger-setup. This uses the same reference as the submit action without needing agithub_refResolved issues
NA
Documentation
Web service API changes
Tests
Tested on this run for backward compatibility calling this submit action from another workflow: https://github.com/canonical/tf-submit-action-test/actions/runs/24295950198/job/70940894955
Dev has also confirmed this approach works on this MM thread: https://chat.canonical.com/canonical/pl/w3g3pi4d5insfb5ndny7srzema