Skip to content

fix(submit): allow submit to be called by nested composite actions#1014

Merged
rene-oromtz merged 2 commits intomainfrom
fix/submit-nested-actions
Apr 15, 2026
Merged

fix(submit): allow submit to be called by nested composite actions#1014
rene-oromtz merged 2 commits intomainfrom
fix/submit-nested-actions

Conversation

@rene-oromtz
Copy link
Copy Markdown
Contributor

@rene-oromtz rene-oromtz commented Apr 13, 2026

Description

The current github_ref that is used so the testflinger-setup has the same reference as the submit action and it work in almost all but one edge case.

Whenever calling the submit action from another composite action in "Repo B" which is then called from a third repo called "Repo C" and using a specified hash or tag, it will not honor the revision from which the submit action is called e.g.
repoC: uses actionB@my-branch
repoB: actionB uses submit@submit/v1.4.4

The github_ref will then be set to my-branch which does not exist in this repository causing a failure.
To enable developers to test local changes on composite action, this PR changes to github.action_path to create a local copy of the testflinger-setup. This uses the same reference as the submit action without needing a github_ref

Resolved issues

NA

Documentation

Web service API changes

Tests

Tested on this run for backward compatibility calling this submit action from another workflow: https://github.com/canonical/tf-submit-action-test/actions/runs/24295950198/job/70940894955

Dev has also confirmed this approach works on this MM thread: https://chat.canonical.com/canonical/pl/w3g3pi4d5insfb5ndny7srzema

@rene-oromtz rene-oromtz requested a review from ajzobro April 13, 2026 15:20
ajzobro
ajzobro previously approved these changes Apr 15, 2026
Comment thread .github/actions/queue-status/action.yaml Outdated
Comment thread .github/actions/submit/action.yaml Outdated
@ajzobro
Copy link
Copy Markdown
Collaborator

ajzobro commented Apr 15, 2026

Looks good to me, not sure if my understanding of the comment is right though.

@rene-oromtz
Copy link
Copy Markdown
Contributor Author

rene-oromtz commented Apr 15, 2026

@ajzobro thanks for the review! I just pushed your suggestions regarding the comments

@rene-oromtz rene-oromtz requested a review from ajzobro April 15, 2026 22:56
Copy link
Copy Markdown
Collaborator

@ajzobro ajzobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rene-oromtz rene-oromtz merged commit 12eba2d into main Apr 15, 2026
2 checks passed
@rene-oromtz rene-oromtz deleted the fix/submit-nested-actions branch April 15, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants