CERTTF-448 Agent changes to receive logs from Conserver instance#469
Open
CERTTF-448 Agent changes to receive logs from Conserver instance#469
Conversation
543d59d to
2072b33
Compare
2072b33 to
e408166
Compare
2f7dbdb to
9581ee7
Compare
9581ee7 to
cedb5fd
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in a week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR gives the agent the ability to get serial console output from a Conserver server, post it to the Testflinger server, and save it in a artifact. This required several changes:
runfunction was split up into a couple different functions:create_command_thread: Creates and starts the thread to run the command and stores it as a instance variablemonitor_command_output: Checks the stop conditions and posts command output to the handlersrun_asyncfunction was addedrunblocks the main thread during the duration of the command run, it is unsuitable for continuously streaming output from conserver.monitor_command_outputfunction as a separate thread.kill_asyncfunction was addedcleanup_runners, is ran on termination signal now.Resolved issues
Resolves https://warthogs.atlassian.net/browse/CERTTF-448
Documentation
Web service API changes
N/A
Tests
Unit tests were added to test_serial.py