Skip to content

Add tests to ensure states are properly preserved between unmaps and remaps#404

Draft
tarek-y-ismail wants to merge 1 commit intomainfrom
surface-unmap-remap-tests
Draft

Add tests to ensure states are properly preserved between unmaps and remaps#404
tarek-y-ismail wants to merge 1 commit intomainfrom
surface-unmap-remap-tests

Conversation

@tarek-y-ismail
Copy link
Contributor

Follow up of canonical/mir#4694

Adds a bunch of tests to make sure SurfaceStateTracker properly preserves surface states when surfaces are unmapped and then remapped.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive test coverage to verify that the SurfaceStateTracker in Mir properly preserves window states (restored, maximized, fullscreen) when surfaces are unmapped and then remapped. This is a follow-up to PR #4694 which fixed a bug where windows would incorrectly revert to the restored state after unmap/remap cycles.

Changes:

  • Added five new test cases covering different state preservation scenarios during unmap/remap cycles
  • Tests verify that restored, maximized, fullscreen, and combined states are maintained
  • Includes a test for multiple consecutive unmap/remap cycles

@tarek-y-ismail tarek-y-ismail changed the title Add tests to ensure states are properly perserved between unmaps and remaps Add tests to ensure states are properly preserved between unmaps and remaps Feb 19, 2026
@tarek-y-ismail tarek-y-ismail force-pushed the surface-unmap-remap-tests branch from 2b17c67 to 0eb4593 Compare February 19, 2026 09:21
@tarek-y-ismail tarek-y-ismail force-pushed the surface-unmap-remap-tests branch from 0eb4593 to 5e24788 Compare February 19, 2026 09:50
@tarek-y-ismail tarek-y-ismail marked this pull request as ready for review February 19, 2026 10:03
@tarek-y-ismail tarek-y-ismail requested a review from a team as a code owner February 19, 2026 10:03
@github-actions
Copy link

TICS Quality Gate

✔️ Passed

No changed files applicable for TICS analysis quality gating.

TICS / TICS / Run TICS analysis

@AlanGriffiths
Copy link
Contributor

WLCS is not about testing details of Mir's current implementation. It is about testing the conformance of any Wayland compositor.

Adds a bunch of tests to make sure SurfaceStateTracker properly preserves surface states when surfaces are unmapped and then remapped.

These tests may or may not be valid (I haven't looked), but this description is about a detail of Mir's implementation. Please rephrase to describe behaviour(s) mandated by Wayland

@tarek-y-ismail
Copy link
Contributor Author

Putting this aside for now until we settle on canonical/mir#4694

@tarek-y-ismail tarek-y-ismail marked this pull request as draft February 20, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants