Skip to content

Complete script names if no workshop names match partial argument#453

Merged
dmitry-lyfar merged 1 commit into
mainfrom
chore/script-partial-complete
Aug 8, 2025
Merged

Complete script names if no workshop names match partial argument#453
dmitry-lyfar merged 1 commit into
mainfrom
chore/script-partial-complete

Conversation

@jonathan-conder
Copy link
Copy Markdown
Contributor

Description

I always type workshop run te<TAB> and get no suggestions. This makes it complete to workshop run test (if there's a test script) but preserves the behaviour of workshop run <TAB> only completing workshop names.

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Or:

  • I confirm the PR has no implications for documentation.

@jonathan-conder jonathan-conder self-assigned this Aug 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 7, 2025

TICS Quality Gate

✔️ Passed

workshop

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project
  • cmd/workshop/exec_test.go
  • cmd/workshop/exec.go

Automatic-tests / code-coverage / TICS GitHub Action

@dmitry-lyfar dmitry-lyfar merged commit 9a15b6d into main Aug 8, 2025
10 checks passed
@dmitry-lyfar dmitry-lyfar deleted the chore/script-partial-complete branch August 8, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants