Remove unused SDK volumes

[dmitry-lyfar]

Description

Implement tracking and removing unused SDK volumes. The implementation uses a clean up handler for the tasks of install-sdk or unregister-sdk type. Once a change with such a task is complete, it may indicate that an SDK volume became unused due to:

• workshop was removed
• SDK volume was detached from a workshop as a result of a refresh change and is no longer used by any other workshop
• workshop launch failed

If an SDK volume is found to be unused for longer than the cool down time (1 hr), it will be removed from the system. This is done to prevent workshopd to remove volumes that have a high chance to be immediately reused on a following refresh or launch.

Self-review quick check

• Make decisions that cost a lot to reverse explicit in the PR description.
• Avoid nested conditions.
• Delete dead code and redundant comments.
• Normalise symmetries by sticking to doing identical things identically.

// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...

• Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
• Put variable declaration and initialisation together.
• Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
• Put a blank line between two logically different chunks of code.
• Follow the style guide for new error messages.

Docs

• I have checked and added or updated relevant documentation.
• I have checked and added or updated relevant release notes.
• I have included the technical author in the review.

Or:

• I confirm the PR has no implications for documentation.

[Copilot]

Pull Request Overview

This PR implements tracking and removal of unused SDK volumes through a cooldown-based cleanup mechanism. The implementation uses cleanup handlers for install-sdk and unregister-sdk tasks to identify unused volumes after workshop removal, SDK detachment, or launch failures, with a 1-hour cooldown period before deletion.

• Adds volume usage tracking by mapping volumes to workshops/projects
• Implements cleanup handlers that delete unused SDK volumes after cooldown period
• Refactors volume data structures to separate setup information from usage tracking

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/workshop/workshop.go	Removes unused WorkshopName function
internal/workshop/lxd/tests/integration/workshop_test.go	Updates tests for new volume structure and adds volume usage tracking tests
internal/workshop/lxd/tests/helper/helper.go	Renames parameter for clarity in MockSdkTarball
internal/workshop/lxd/lxd_backend_volume.go	Implements volume usage tracking and parsing workshop/project info from URLs
internal/workshop/lxd/lxd_backend_project.go	Uses relocated workshopName function
internal/workshop/lxd/lxd_backend.go	Adds helper functions for workshop name parsing
internal/workshop/fakebackend/backend.go	Updates fake backend to support new volume tracking structure
internal/workshop/backend.go	Splits VolumeInfo into VolumeSetup and adds workshop tracking
internal/overlord/workshopstate/request.go	Updates for new volume structure
internal/overlord/workshopstate/handlers.go	Updates for new volume structure
internal/overlord/sdkstate/manager.go	Adds cleanup handlers for SDK volume management
internal/overlord/sdkstate/handlers_test.go	Adds comprehensive tests for volume cleanup behavior
internal/overlord/sdkstate/handlers.go	Implements the core cleanup logic with cooldown tracking
internal/overlord/ifacestate/ifacemgr_test.go	Updates test for new volume structure
internal/overlord/hookstate/handlers_test.go	Updates tests for new volume structure
internal/daemon/api_workshops_test.go	Adds volume cleanup verification to integration tests
internal/daemon/api_workshops.go	Sets error status on failed workshop operations
.github/workflows/cover.yaml	Removes unused branchname parameter

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[github-actions]

TICS Quality Gate

✔️ Passed

workshop

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project

• internal/daemon/api_workshops.go
• internal/overlord/sdkstate/handlers.go
• internal/overlord/sdkstate/manager.go
• internal/overlord/workshopstate/handlers.go
• internal/overlord/workshopstate/request.go
• internal/workshop/backend.go
• internal/workshop/fakebackend/backend.go
• internal/workshop/lxd/lxd_backend_project.go
• internal/workshop/lxd/lxd_backend_volume.go
• internal/workshop/lxd/lxd_backend.go
• internal/workshop/workshop.go

Automatic-tests / code-coverage / TICS GitHub Action