Skip to content

Improve test coverage for base-agnostic SDKs#458

Merged
dmitry-lyfar merged 1 commit into
mainfrom
chore/baseless
Aug 15, 2025
Merged

Improve test coverage for base-agnostic SDKs#458
dmitry-lyfar merged 1 commit into
mainfrom
chore/baseless

Conversation

@jonathan-conder
Copy link
Copy Markdown
Contributor

Description

I think this is working as intended but I only added tests for the architecture changes, not the base changes. Not sure why.

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Or:

  • I confirm the PR has no implications for documentation.

@github-actions
Copy link
Copy Markdown

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'workshop' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-08-14 03:36:53.000 by user ubuntu.

Automatic-tests / code-coverage / TICS GitHub Action

@dmitry-lyfar dmitry-lyfar merged commit fad3adb into main Aug 15, 2025
9 of 10 checks passed
@dmitry-lyfar dmitry-lyfar deleted the chore/baseless branch August 15, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants