Skip to content

Make verbose mode off for sketch-sdk by default#462

Merged
dmitry-lyfar merged 1 commit into
mainfrom
chore/sketch-verbose
Aug 21, 2025
Merged

Make verbose mode off for sketch-sdk by default#462
dmitry-lyfar merged 1 commit into
mainfrom
chore/sketch-verbose

Conversation

@dmitry-lyfar
Copy link
Copy Markdown
Collaborator

@dmitry-lyfar dmitry-lyfar commented Aug 20, 2025

Description

  1. Verbose mode does not seem to be a good choice to have on by default for sketch-sdk, especially if it's used for many consequential iterations. Add --verbose flag to control this behaviour similarly to refresh.
  2. @akcano I turned the project-starter-pack temporarily from the project as it prevents the workshop from launching. It should come back with your fix.

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Or:

  • I confirm the PR has no implications for documentation.

Comment thread cmd/workshop/sketch.go
@github-actions
Copy link
Copy Markdown

TICS Quality Gate

✔️ Passed

workshop

All conditions passed

See the results in the TICS Viewer

The following files have been checked for this project
  • cmd/workshop/sketch.go

Automatic-tests / code-coverage / TICS GitHub Action

@dmitry-lyfar dmitry-lyfar merged commit 2f905b2 into main Aug 21, 2025
11 checks passed
@dmitry-lyfar dmitry-lyfar deleted the chore/sketch-verbose branch August 21, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants