Skip to content

Add pack to bare snapcraft and sdkcraft commands#467

Merged
dmitry-lyfar merged 2 commits into
mainfrom
chore/sdkcraft-pack
Aug 29, 2025
Merged

Add pack to bare snapcraft and sdkcraft commands#467
dmitry-lyfar merged 2 commits into
mainfrom
chore/sdkcraft-pack

Conversation

@jonathan-conder
Copy link
Copy Markdown
Contributor

Description

Craft tools are deprecating default commands soon. We should switch to avoid unnecessary warnings. I also changed a few things in the snap remove hook, because I used to run it manually sometimes and that doesn't work at the moment.

Self-review quick check

  • Make decisions that cost a lot to reverse explicit in the PR description.
  • Avoid nested conditions.
  • Delete dead code and redundant comments.
  • Normalise symmetries by sticking to doing identical things identically.
// one way to handle errors
if err := f(); err != nil {
   ...
}

// one way to handle multiple returns
val, err := f()
if err != nil {
   ...
}
...
  • Check that coupled code elements, files, and directories are adjacent. For example, test data is stored as close as possible to a test.
  • Put variable declaration and initialisation together.
  • Divide large expressions into digestable and self-explanatory ones. Use multiple variables if required.
  • Put a blank line between two logically different chunks of code.
  • Follow the style guide for new error messages.

Docs

  • I have checked and added or updated relevant documentation.
  • I have checked and added or updated relevant release notes.
  • I have included the technical author in the review.

Or:

  • I confirm the PR has no implications for documentation.

@github-actions
Copy link
Copy Markdown

TICS Quality Gate

✔️ Passed

No changed files applicable for TICS analysis quality gating.

Automatic-tests / code-coverage / TICS GitHub Action

@dmitry-lyfar dmitry-lyfar merged commit f795948 into main Aug 29, 2025
13 checks passed
@dmitry-lyfar dmitry-lyfar deleted the chore/sdkcraft-pack branch August 29, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants