Doc: Restructure how-tos, explanation#489
Merged
Merged
Conversation
Collaborator
dmitry-lyfar
left a comment
dmitry-lyfar
left a comment
There was a problem hiding this comment.
I left some notes, but I also think you should reconsider the Hooks explanation's structure. Something feels off here.
Note that we have an intro paragraph on hooks in SDK concepts itself that is very similar to what is written here in the first paragraph. We also have a beautiful https://canonical-workshop--489.com.readthedocs.build/489/reference/sdks/#sdk-hooks that explains the order of execution for hooks.
So the only reason for this to exist is to explain workshopctl and check-health and I'm not sure it's right place for it. Need your help with this.
Co-authored-by: Dmitry Lyfar <69887876+dmitry-lyfar@users.noreply.github.com>
dmitry-lyfar
approved these changes
Oct 1, 2025
Collaborator
dmitry-lyfar
left a comment
dmitry-lyfar
left a comment
There was a problem hiding this comment.
This structure is much cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.