[BugFix]: Skip error#89
Merged
Merged
Conversation
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
Signed-off-by: Douglas Chiang <douglas.chiang@canonical.com>
p-gentili
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently, we discovered that when a robot script has just one test and it is skipped,
_end_suite()will log a video usinglogger.error(), which raises an actual error and stops a suite from proceeding to the next one. This PR changes the checking fromnot result.passedtoresult.failedso that we only log the video only when a suite is failed.Resolved issues
N/A
Documentation
N/A
Tests
testing...