pdo: Fix wrongfully returned object for missing index#636
Merged
acolomb merged 2 commits intocanopen-python:masterfrom Apr 7, 2026
Merged
pdo: Fix wrongfully returned object for missing index#636acolomb merged 2 commits intocanopen-python:masterfrom
acolomb merged 2 commits intocanopen-python:masterfrom
Conversation
Must raise a KeyError, but currently does not.
Fixes the test failure introduced with previous commit.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback behavior in
PdoMaps.__getitem__()tried looking up by parameter record index even when nocom_offsetormap_offsetwas defined. This caused a possibly wrongPdoMapobject to be returned. For example with 0x15FF, the lookup for 0x1600 would succeed.Add a test to make sure that an nonexistant parameter record index for 0x15FF actually does raise a
KeyError. Skip the fallback lookup by parameter index if no record offsets are defined.