Security: enforce trusted renderer origins (preload + navigation + IPC)#1904
Merged
gregpriday merged 1 commit intomainfrom Jan 28, 2026
Merged
Conversation
- Add environment-aware origin allowlist (dev origins only in development) - Implement preload API gating with main-frame check - Add global IPC sender validation via monkey-patch - Block same-window navigations/redirects to untrusted URLs - Add comprehensive unit tests for origin validation - Update existing IPC handler tests with mock senderFrame - Configure test environment for development mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements defense-in-depth security controls to enforce trusted renderer origins across three critical layers: preload API exposure, navigation guards, and IPC sender validation. This prevents untrusted origins from accessing privileged APIs even if the main window is compromised via XSS or navigation attacks.
Closes #1889
Changes Made
Security Improvements
window.electronAPI only exposed to main frame of trusted originswill-navigateandwill-redirectevents block untrusted destinationslocalhost:5173,127.0.0.1:5173) only trusted in developmentTesting