Harden Hugging Face Space deployment#25
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)✅ Unit Test PR creation complete.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Apache License 2.0 and significantly updates the README.md by formatting architecture diagrams, deployment instructions, and local development steps into code blocks. It also adds gradio to the project requirements. Feedback includes a recommendation to pin the gradio version to 6.13.0 for consistency and a note regarding the missing sync-huggingface.yml workflow file mentioned in the documentation.
| @@ -1,3 +1,4 @@ | |||
| gradio>=6.13.0,<7 | |||
There was a problem hiding this comment.
To ensure local development perfectly matches the Hugging Face Space environment (as stated in the PR summary), it is recommended to pin gradio to the exact version specified in the README.md frontmatter (6.13.0) rather than using a range. This prevents potential drift if a newer version within the range is installed locally.
gradio==6.13.0
| app_file: app.py | ||
| ``` | ||
|
|
||
| The GitHub workflow `.github/workflows/sync-huggingface.yml` deploys GitHub `main` to Hugging Face after the `CI` workflow succeeds on `main`. Manual dispatch is also available from the Actions tab. |
There was a problem hiding this comment.
The documentation describes updates to .github/workflows/sync-huggingface.yml and the use of the HF_SPACE_NAME secret, but the workflow file itself is not included in this pull request. Please ensure the workflow file is added to the PR to match the documentation and complete the implementation.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by nemotron-3-super-120b-a12b-20230311:free · 320,148 tokens |
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
Review follow-up for
No other review findings were changed. |
|
✅ Created PR with unit tests: #26 |
Summary
This PR hardens the Hugging Face Space deployment circuit with a small, focused set of changes:
gradio>=6.13.0,<7runtime dependency so local installs and HF builds share the same dependency contract as the Space metadata..github/workflows/sync-huggingface.ymlso GitHub-to-Hugging Face sync runs only after theCIworkflow succeeds onmain, while keeping manual dispatch available.HF_SPACE_NAMEsupport so the Hugging Face Space name can differ from the GitHub repository name.README.md.LICENSEfile to match README frontmatter and badges.Required configuration
GitHub repository secrets:
Optional GitHub repository secret:
Required Hugging Face Space secret:
Reverse sync only:
Testing
Not run locally; changes were made through the GitHub connector. CI should validate workflow-adjacent repo checks after the PR is opened.