Merged
Conversation
Poppler changed to this as of 21.12.0.
This uses the sensiblecodeio fork with two reverted commits: * right-to-left text ordering * rotated text handling Both of these change outputs of pdf2msgpack substantially. They can be reviewed later to see if the pdf2msgpack code can be changed to retain this existing behaviour, while removing the reverts.
`std::optional` for font name: https://gitlab.freedesktop.org/poppler/poppler/-/commit/996dfb015f5567cdaf191c127c2cf804f852d80b The C++ 17 standard allows checking this with `value_or`, so we don't need the `?` if…then…else construct. `Catalog::embeddedFile`: https://gitlab.freedesktop.org/poppler/poppler/-/commit/beb5519f723cd84d8d4afa989118df5fffbe50fb?merge_request_iid=1064
The default value was changed in Poppler commit f20d9e5f739b7c8dce74ebc60a6dd1e06106c12e. It is overridable, so we should change it back to what it was for now, to keep outputs unchanged.
StevenMaude
commented
Nov 27, 2023
Comment on lines
+523
to
+525
| // Original | ||
| // GooString goo_filename(filename.c_str()); | ||
| // auto file = GooFile::open(&goo_filename); |
Contributor
Author
There was a problem hiding this comment.
This should be removed, but I'll do that in another PR as I've tested with the code as it is in this current PR, and the SHA256 of the binary might change (although it's a comment, so it should be stripped out).
This was referenced Nov 27, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.