Skip to content

Don't insert unicode names twice: #86 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StevenMaude merged 1 commit into from
Sep 17, 2015
Merged

Don't insert unicode names twice: #86 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scraperwiki/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def fit_row(connection, row, unique_keys):
new_column = sqlalchemy.Column(column_name,
get_column_type(column_value))

if not str(new_column) in list(_State.table.columns.keys()):
if not column_name in list(_State.table.columns.keys()):
new_columns.append(new_column)
_State.table.append_column(new_column)

Expand Down
5 changes: 5 additions & 0 deletions tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,11 @@ def test_raises_exception_with_invalid_type_field(self):

# XXX neeed some mocking tests for case of run inside a box

class TestUnicodeColumns(TestCase):
maxDiff = None
def test_add_column_once_only(self):
scraperwiki.sqlite.save(data = {"i": 1, u"a\xa0b": 1}, unique_keys = ['i'])
scraperwiki.sqlite.save(data = {"i": 2, u"a\xa0b": 2}, unique_keys = ['i'])

class TestImports(TestCase):

Expand Down