Add copilot-instructions.md#7
Merged
Merged
Conversation
Signed-off-by: Stas German (SBI) <stasge+sbi@sbisecsol.com>
Signed-off-by: Stas German (SBI) <stasge+sbi@sbisecsol.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Stas German (SBI) <stasge+sbi@sbisecsol.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new documentation file outlining guidelines for GitHub workflows and shell scripts.
- Specifies workflow permission settings and version pinning rules
- Enforces use of environment variables in shell snippets
- Requires shell scripts to pass ShellCheck
Comments suppressed due to low confidence (4)
.github/copilot-instructions.md:4
- Clarify that in YAML this should appear as
permissions: {}rather than a string literal'{}'to avoid confusion.
- permissions are set to '{}' for workflow and overridden for each job where needed
.github/copilot-instructions.md:5
- [nitpick] Use consistent casing for
GitHuband consider rephrasing to "official GitHub Actions" for clarity.
- versions of github actions are pinned to a specific commit unless the action belongs to one of: the same organization (global-synchronizer-foundation), github official actions
.github/copilot-instructions.md:6
- [nitpick] Consider rewording to explicitly state: "In
run:steps, avoid template placeholders; use environment variables instead."
- shell snippets (under `run:`) don't have templated variables and environment variables are used instead
.github/copilot-instructions.md:9
- [nitpick] Expand this to "Shell scripts must pass ShellCheck linting without warnings" for clearer requirements.
- conforms to ShellCheck
Signed-off-by: Stas German (SBI) <stasge+sbi@sbisecsol.com>
Contributor
Author
|
@tkatrichenko would you help me to review this and then we'd run these instructions against another PR? |
tkatrichenko
approved these changes
Jul 8, 2025
Contributor
|
Yeah. Let's try it with my PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.