Tighten Python reference doc types#684
Merged
Merged
Conversation
danielporterda
force-pushed
the
python-type-tightening
branch
from
1a79b7b to
e42254e
Compare
danielporterda
force-pushed
the
python-type-tightening
branch
from
e42254e to
aea07fe
Compare
da-tanabe
reviewed
Jun 2, 2026
|
|
||
| from x2mdx.types import JsonObject | ||
|
|
||
| DamlJsonModule = JsonObject |
Collaborator
There was a problem hiding this comment.
This isn't really a significant improvement… I'd honestly rather never we redeclare JsonObject because now it's just misleading me into thinking I have better types where in fact, I don't…
da-tanabe
reviewed
Jun 2, 2026
Comment on lines
+9
to
+10
| TypeDocDocument = JsonObject | ||
| TypeDocExport = JsonObject |
Collaborator
There was a problem hiding this comment.
here too… this doesn't add anything
da-tanabe
approved these changes
Jun 2, 2026
Collaborator
da-tanabe
left a comment
da-tanabe
left a comment
There was a problem hiding this comment.
There are some improvements, so already better than what we have, but I'd rather have real types for the places I called out in the PR (ok for this to be a subsequent PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MintlifyNavGroupTypedDictfor Mintlify navigation items.Any/generic aliases in AsyncAPI and OpenRPC models with format-specificTypedDictrecords for documents, extracted detail rows, change details, and history buckets.docs.jsonnavigation lists.