Skip to content

CIP 0104: Traffic Weighted App Rewards: Serve Traffic Summarys from /v0/events#4263

Merged
adetokunbo merged 27 commits intomainfrom
adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0
Mar 9, 2026
Merged

CIP 0104: Traffic Weighted App Rewards: Serve Traffic Summarys from /v0/events#4263
adetokunbo merged 27 commits intomainfrom
adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0

Conversation

@adetokunbo
Copy link
Copy Markdown
Contributor

@adetokunbo adetokunbo commented Mar 5, 2026 •
edited
Loading

Follows #4037
Replaces #4154, postponing the inclusion of AppActivityRecords in the endpoint, while adding an integration test and release notes
Tracked in #4191
Fixes #3824

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@adetokunbo adetokunbo self-assigned this Mar 5, 2026
@adetokunbo adetokunbo mentioned this pull request Mar 5, 2026
Closed
6 tasks
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0 branch from 7058f82 to 9e7e9ca Compare March 5, 2026 01:47
dfordivam
dfordivam reviewed Mar 5, 2026
View reviewed changes
Comment thread docs/src/release_notes_upcoming.rst Outdated
Comment thread test-full-class-names.log Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
dfordivam
dfordivam reviewed Mar 5, 2026
View reviewed changes
Comment thread docs/src/release_notes_upcoming.rst Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
meiersi-da
meiersi-da reviewed Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Overall structure looks good.

Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread ...lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryExtraDataIntegrationTest.scala Outdated
Comment thread apps/scan/src/main/openapi/scan.yaml
Comment thread apps/scan/src/main/openapi/scan.yaml Outdated
Comment thread apps/scan/src/main/openapi/scan.yaml Outdated
Comment thread apps/scan/src/main/openapi/scan.yaml Outdated
Comment thread apps/scan/src/main/openapi/scan.yaml Outdated
Comment thread docs/src/release_notes_upcoming.rst Outdated
@adetokunbo adetokunbo changed the base branch from adetokunbo/cip-0104-composite-ingestion to adetokunbo/cip-0104-composite-ingestion-1-commit March 5, 2026 10:02
Base automatically changed from adetokunbo/cip-0104-composite-ingestion-1-commit to main March 5, 2026 11:08
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0 branch 3 times, most recently from e788a82 to 7c3bacf Compare March 5, 2026 20:47
@adetokunbo
Copy link
Copy Markdown
Contributor Author

adetokunbo commented Mar 5, 2026

@meiersi-da PTAL, comments should be addressed.

dfordivam
dfordivam reviewed Mar 6, 2026
View reviewed changes
Comment thread docs/src/release_notes_upcoming.rst
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0 branch from 33de137 to 9743a8a Compare March 6, 2026 02:27
meiersi-da
meiersi-da reviewed Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more polish on the API defs, and we're good to go.

Comment thread ...cala/org/lfdecentralizedtrust/splice/integration/tests/ScanEventHistoryIntegrationTest.scala
Comment thread apps/scan/src/main/openapi/scan.yaml Outdated
Comment thread docs/src/release_notes_upcoming.rst
adetokunbo and others added 12 commits March 9, 2026 01:15
@adetokunbo
Add traffic summary as part of EventHistoryItem in scan.yaml
36de0f6 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Serve traffic summaries in /v0/events
3fdcea1 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo @dfordivam
Update traffic cost description in scan.yaml
9c59cfd 
Co-authored-by: Divam <681060+dfordivam@users.noreply.github.com>
Signed-off-by: Timothy Emiola <adetokunbo@users.noreply.github.com>
@adetokunbo @dfordivam
Update traffic summary description in scan.yaml
d5425e2 
Co-authored-by: Divam <681060+dfordivam@users.noreply.github.com>
Signed-off-by: Timothy Emiola <adetokunbo@users.noreply.github.com>
@adetokunbo
Add an experimental note to traffic_summary
9cf9baa 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo @dfordivam
Update description of view IDs in scan.yaml
0793d6e 
Co-authored-by: Divam <681060+dfordivam@users.noreply.github.com>
Signed-off-by: Timothy Emiola <adetokunbo@users.noreply.github.com>
@adetokunbo
Update EventHistoryItem description in scan.yaml
5b8bbb1 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Don't show the sequencing time
c242e4c 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Add unit test for encode of api Traffic Summaries
3036f6b 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Gate serving traffic summaries on a config flag
d26151a 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Add ScanEventHistoryExtraDataTest that confirms serving of traffic su…
0c71c46 
…mmaries

- Checks that Traffic Summaries are served when its gating flag is enabled
- Also, includes changes to ScanEventHistoryIntegrationTest itself to confirm
that Traffic Summaries are not served by default

Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Note traffic summary inclusion in release_notes_upcoming.rst
5a9966a 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
adetokunbo added 15 commits March 9, 2026 01:15
@adetokunbo
Fix sort order
e4c93de 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Restore the earlier release note
9906f25 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Improve the integration test
f394374 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Remove unnecessary use of initDsoWithSv1Only
5c9be44 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Remove unnecessary verdict ingestion overrride
ede2df2 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
s/for/foreach/
d44afe6 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Use the shared environment when toxiproxy is not used
2ec9bf5 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Compare the summary by ID with the one from the page
a084e63 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Remove an incorrect assertion
05d0b7b 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
s/envelope_traffic_costs/envelope_traffic_summaries/
5bd0537 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
Improve descriptions in scan.yaml
99b3149 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Remove unused traits
24f81aa 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[static] Remove earlier accepted diff (merge error)
ac25ec6 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
s/EnvelopeTrafficCost/EnvelopeTrafficSummary/
f01dd12 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
[ci] Provide more info in the release notes
c141e91 
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo adetokunbo force-pushed the adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0 branch from 9743a8a to c141e91 Compare March 9, 2026 01:35
@adetokunbo
Copy link
Copy Markdown
Contributor Author

adetokunbo commented Mar 9, 2026

Some more polish on the API defs, and we're good to go.

I've just addressed those comments, PTAL @meiersi-da

meiersi-da
meiersi-da approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @adetokunbo 🙏

@adetokunbo adetokunbo merged commit 527bb9f into main Mar 9, 2026
125 of 128 checks passed
@adetokunbo adetokunbo deleted the adetokunbo/cip-0104-serve-traffic-summaries-in-events-v0 branch March 9, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfordivam dfordivam dfordivam left review comments

@meiersi-da meiersi-da meiersi-da approved these changes

@rautenrieth-da rautenrieth-da Awaiting requested review from rautenrieth-da

Assignees

@adetokunbo adetokunbo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scan app: Ingest TrafficSummaries and serve on /v0/events endpoint

3 participants

@adetokunbo @dfordivam @meiersi-da