Cleanup some of the dependency imports#1327
Merged
Conversation
Saves 800 bytes on min.js
aearly
reviewed
Nov 17, 2016
|
|
||
| export default function _asyncMap(eachfn, arr, iteratee, callback) { | ||
| callback = once(callback || noop); | ||
| callback = callback || noop; |
Collaborator
Author
There was a problem hiding this comment.
nope, each/eachLimit/eachSeries gaurentee that we'll only ever be calling callback once
aearly
reviewed
Nov 17, 2016
| if (isArray(taskFn)) { | ||
| params = clone(taskFn); | ||
| taskFn = params.pop(); | ||
| params = taskFn.slice(0, -1); |
Collaborator
There was a problem hiding this comment.
TIL slice can take negative indexes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves 800 bytes on min.js
fyi _baseRest imports a bunch of string manipulation code to manage setting
func.toStringon the output function