Merged
Conversation
On such platform math is provided .e.g. on UCRT library. That is true for both MSYS2 .a and MSVC .lib libraries. The configure.ac was already aware of that on SYS_LIBM but some references scaped that check.
caolanm
approved these changes
Apr 4, 2026
| #ifndef WMFPLAYER_COLOR_H | ||
| #define WMFPLAYER_COLOR_H | ||
|
|
||
| #ifdef _WIN32 |
Owner
There was a problem hiding this comment.
Having this duplicate in two places feels a bit wonky, but I can like with it
13 tasks
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I am working on making libwmf build on vcpkg environment and would like the following commits to be merged. This helps building GIMP with MSVC. Thanks in advance