fix: skip rescan-on-download when no malware scanner is bound

[Schmarvinius]

Fix: Skip Rescan-on-Download When No Malware Scanner Is Bound

Bug Fix

🐛 Fixed an issue where the ReadAttachmentsHandler would attempt to trigger rescan-on-download logic even when no malware scanner service is bound. When scanClient is null (i.e., no malware scanning service is available), stale or unscanned attachments should not be queued for rescanning on download.

Changes

• Registration.java: Passes scanClient != null as the scannerAvailable flag when constructing ReadAttachmentsHandler, ensuring the handler is aware of whether a malware scanner is actually bound.

• ReadAttachmentsHandler.java: Added a scannerAvailable boolean field and updated the constructor to accept it. The verifyStatus method now short-circuits the rescan check when scannerAvailable is false, preventing unnecessary scan attempts when no scanner is configured.

• ReadAttachmentsHandlerTest.java: Updated the existing handler instantiation to pass true for scannerAvailable. Added three new test cases covering the scannerAvailable = false scenario:

  • Stale clean attachments are not re-triggered for scanning.
  • Clean attachments with a null scannedAt timestamp are not re-triggered.
  • Attachments with UNSCANNED status still fail validation as expected (status validation is unaffected by scanner availability).

• 🔄 Regenerate and Update Summary

---

📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

PR Bot Information

Version: 1.20.4 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• LLM: anthropic--claude-4.6-sonnet
• Output Template: Default Template
• Event Trigger: pull_request.opened
• File Content Strategy: Full file content
• Summary Prompt: Default Prompt
• Correlation ID: 9c915e60-33f6-11f1-8c2d-1502b3e0d84c

[hyperspace-insights]

The PR is well-structured and the core logic change is correct. The only notable issue is the repeated construction of handlerWithoutScanner across three test methods, which should be refactored into a shared helper to reduce duplication and improve maintainability. The production code changes in ReadAttachmentsHandler and Registration are clean and correctly implement the intended behavior.

PR Bot Information

Version: 1.20.4 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• LLM: anthropic--claude-4.6-sonnet
• Event Trigger: pull_request.opened
• File Content Strategy: Full file content
• Correlation ID: 9c915e60-33f6-11f1-8c2d-1502b3e0d84c