Skip to content

Added build final name property and java doc and source plugins #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

Added build final name property and java doc and source plugins #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c40bb1
Add deploy-oss
mtsvetanov071 Jul 3, 2025
963dcd7
Merge branch 'main' of github.com:cap-java/cds-feature-auditlog-ng
mtsvetanov071 Jul 3, 2025
034b8a8
Add finalName and fix the java doc
mtsvetanov071 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions cds-feature-auditlog-ng/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,40 @@
</dependencies>

<build>
<finalName>${project.artifactId}</finalName>
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<failIfNoTests>false</failIfNoTests>
</configuration>
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<skip>${skipDuringDeploy}</skip>
<failOnError>true</failOnError>
<doclint>all,-missing</doclint>
</configuration>
<executions>
<execution>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<artifactId>maven-source-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
4 changes: 0 additions & 4 deletions ...ure-auditlog-ng/src/main/java/com/sap/cds/feature/auditlog/ng/AuditLogNGCommunicator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@
import com.sap.cloud.sdk.cloudplatform.resilience.ResilienceDecorator;
import com.sap.cloud.sdk.cloudplatform.resilience.ResilienceIsolationMode;

/**
* Implementation for an audit log {@link Communicator} which provides
* connectivity to the audit log api via the Cloud SDK.
*/
public class AuditLogNGCommunicator {

private static final Logger logger = LoggerFactory.getLogger(AuditLogNGCommunicator.class);
Expand Down
10 changes: 5 additions & 5 deletions ...uditlog-ng/src/main/java/com/sap/cds/feature/auditlog/ng/CertificateHttpClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
/**
* Provides a configurable HTTP client for certificate-based authentication with retry logic.
* Usage example:
* CloseableHttpClient client = RetryHttpClientConfig.builder()
* CloseableHttpClient client = CertificateHttpClientConfig.builder()
* .certPem(certString)
* .keyPem(keyString)
* .keyPassphrase(passphrase) // optional, only for encrypted keys
Expand Down Expand Up @@ -84,7 +84,7 @@ public CloseableHttpClient getHttpClient() {
}

/**
* Returns a builder for {@link RetryHttpClientConfig}.
* Returns a builder for {@link CertificateHttpClientConfig}.
*
* @return a new Builder instance
*/
Expand All @@ -93,7 +93,7 @@ public static Builder builder() {
}

/**
* Builder for {@link RetryHttpClientConfig}.
* Builder for {@link CertificateHttpClientConfig}.
* <p>
* All fields are optional except for certPem and keyPem, which are required.
* </p>
Expand Down Expand Up @@ -152,8 +152,8 @@ public Builder timeoutMillis(int timeoutMillis) {
return this;
}
/**
* Builds the {@link RetryHttpClientConfig} instance.
* @return a configured RetryHttpClientConfig
* Builds the {@link CertificateHttpClientConfig} instance.
* @return a configured CertificateHttpClientConfig
* @throws IllegalArgumentException if certPem or keyPem is missing
*/
public CertificateHttpClientConfig build() {
Expand Down