[SDMEXT-1040]: Support Secondary Properties In Attachments #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'origin' into CustomPropFinalBranch
This reverts commit 236b0d4.
This reverts commit f5a9ba5.
Setting caching for secondary types as infinite as it only needs to be refreshed on application redeployment
maheshsooryambylu
approved these changes
Mar 27, 2025
Collaborator
maheshsooryambylu
left a comment
maheshsooryambylu
left a comment
There was a problem hiding this comment.
Went through the code changes. Code looks fine to me.
rashmiangadi11
approved these changes
Mar 27, 2025
Contributor
Author
|
As discussed, the UT branch coverage has been reduced to 80% which would be covered in the later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to implement the feature requirement of supporting custom properties in attachments.
Jira Link: https://jira.tools.sap/browse/SDMEXT-1040
Wiki Link: https://wiki.one.int.sap/wiki/display/sapecm/Support+Secondary+Properties+In+Attachments