SDMEXT:1871:Delete Flow with authorities(to support user email logged in audit log)#251
Merged
rashmiangadi11 merged 14 commits intodevelopfrom Jul 28, 2025
Merged
SDMEXT:1871:Delete Flow with authorities(to support user email logged in audit log)#251rashmiangadi11 merged 14 commits intodevelopfrom
rashmiangadi11 merged 14 commits intodevelopfrom
Conversation
rishikunnath2747
previously approved these changes
Jul 25, 2025
yashmeet29
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Any documentation
Currently we only have technical credentials flow for delete in our plugin. With this in audit log service it says deleted by clientId but what if a actual user has deleted it. To solve that we generate token by passing authorities as below to the auth url.
authorities=%7B%22az_attr%22%3A%7B%22X-EcmUserEnc%22%3A%22rtest.test%40sapworkspace.com%22%2C%22X-EcmAddPrincipals%22%3A%testUser%22%7D%7D
This is done using a concept from cloud sdk called Oauth2PropertySupplier where the authorities node is formed and passed as options to the destination.
Now when a user deletes the attachment, the user email is captured added to authorities and then the same user email appears in the auditlog for delete folder/document.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested
Below is the screenshot attached for auditlog email logged
