Skip to content

Conversation

@rashmiangadi11
Copy link
Collaborator

@rashmiangadi11 rashmiangadi11 commented Oct 17, 2025

Describe your changes

Currently all messages are kept static and not placed in SDMConstants file. This has been done here. Also the messages are not translated to different languages this is achieved for most of the messages exposed to end user.
If user does not add to messages.properties file under srv/src/main/resources then default message from SDMConstants is shown to user.

One of the integration test is also improved to handle this scenario.

User need to add the translation in messages_[language code].properties file.

Any documentation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I follow Java Development Guidelines for SAP
  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description
Screenshot 2025-10-23 at 8 16 41 PM Screenshot 2025-10-24 at 6 48 44 PM

Scenarrio's Tested

  1. Added a message in message.properties and tested which loads the user specified message.
  2. Added a message in message_de.properties file and changed language in ui and checked the german language message appears.
    3)No message present in .properties then default message in SDMConstants is shown to user.

@yashmeet29
Copy link
Collaborator

@rashmiangadi11, please attach the screenshots of Integration Tests and the list of scenarios tested.

@rashmiangadi11 rashmiangadi11 merged commit 9984cfe into develop Oct 24, 2025
8 checks passed
@rashmiangadi11 rashmiangadi11 deleted the translationissue branch October 24, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants