Skip to content

user defined error msg for maximum upload of attachments#518

Merged
vibhutikumar07 merged 3 commits into
developfrom
deepika/SDMEXT-errorMsgFix-feature
Jun 23, 2026
Merged

user defined error msg for maximum upload of attachments#518
vibhutikumar07 merged 3 commits into
developfrom
deepika/SDMEXT-errorMsgFix-feature

Conversation

@deepikaSingh2711

@deepikaSingh2711 deepikaSingh2711 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes

-> Problem

When users configured a custom error message for the maximum attachment upload limit, the application always displayed the default message:

"Cannot upload more than X attachments."

instead of the user-defined custom message.

-> Root Cause

The leading application was using an incorrect configuration key mapping:

Incorrect: SDM.Attachments.maxCountError
Correct: SDM.maxCountError

As a result, the custom error message configuration was not being picked up.

-> Fix

Updated the key mapping in the leading application from SDM.Attachments.maxCountError to SDM.maxCountError to correctly resolve and display the user-configured error message when the maximum upload limit is exceeded.

-> Validation

Verified that the custom error message is displayed correctly when the attachment upload count exceeds the configured maximum limit.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I follow Java Development Guidelines for SAP
  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description

Before fix

Screenshot 2026-06-19 at 10 54 03 AM

After fix

Screenshot 2026-06-19 at 10 46 56 AM

Single tenant Integration tests

https://github.com/cap-java/sdm/actions/runs/27815453016
Screenshot 2026-06-22 at 11 26 26 PM

Multi tenant Integration tests

https://github.com/cap-java/sdm/actions/runs/27814115842
Screenshot 2026-06-23 at 1 15 04 PM

rashmiangadi05
rashmiangadi05 previously approved these changes Jun 19, 2026
@vibhutikumar07 vibhutikumar07 merged commit 1529f5d into develop Jun 23, 2026
9 checks passed
@vibhutikumar07 vibhutikumar07 deleted the deepika/SDMEXT-errorMsgFix-feature branch June 23, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants