[DINC0374658]:Error message fix when a user with No SDM Roles uploads an attachment#82
Merged
yashmeet29 merged 2 commits intodevelopfrom Jan 22, 2025
Merged
Conversation
yashmeet29
requested review from
PujaDeshmukh17,
rashmiangadi11 and
rishikunnath2747
|
|
||
| try (Response response = client.newCall(request).execute()) { | ||
| if (!response.isSuccessful()) { | ||
| if (response.code() == 403) { |
Collaborator
There was a problem hiding this comment.
can we have switch case to manintain error messages
Collaborator
Author
There was a problem hiding this comment.
@rashmiangadi11 we just have one if-else block here, so I don't think we need a switch case here.
PujaDeshmukh17
approved these changes
Jan 22, 2025
Contributor
PujaDeshmukh17
left a comment
PujaDeshmukh17
left a comment
There was a problem hiding this comment.
Looks good to me.
rashmiangadi11
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a user do not have SDM roles and if they try to upload an attachment, some random error is being thrown. With this PR, we are fixing the error message.