MT: shared case - on unsubscribe deletion #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamIndia
suggested changes
May 5, 2025
| if (profile === 'mtx-sidecar') { | ||
| const ds = await cds.connect.to("cds.xt.DeploymentService"); | ||
| if (separateObjectStore === "separate") { | ||
| ds.after('subscribe', async (_, req) => { |
Contributor
There was a problem hiding this comment.
In many event hook functions, such as ds.after, the callback receives multiple arguments—typically the first being some result or context, and the second being the request object.
In such cases, the underscore _ is commonly used as a placeholder for the first argument to indicate that it is being intentionally ignored, and only the second argument (which is needed) will be used.
| Prefix: tenant, | ||
| }); | ||
|
|
||
| for await (const page of paginator) { |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
aws-sdk doesn't provide methods to directly delete with a given prefix.
re: https://stackoverflow.com/a/3196342
https://docs.aws.amazon.com/AmazonS3/latest/API/s3_example_s3_DeleteObjects_section.html
RamIndia
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.