fix: Enable mixing stream and normal parameters in queries #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
David-Kunz,
danjoa,
gregorwolf,
johannes-vogel,
patricebender,
sebastianesch,
sjvans,
stewsk and
vobu
as code owners
| value.pipe(paramStream) | ||
| value.on('error', err => paramStream.emit('error', err)) | ||
| streams[i] = paramStream | ||
| streams.push(paramStream) |
Member
There was a problem hiding this comment.
could you elaborate why this solves the issue of having undefined values in the streams array? If paramStream is undefined wouldn't both arrays contain the undefined value?
Contributor
Author
There was a problem hiding this comment.
The paramStream is always initialized inside this branch of the logic. The problem happens in the loop which goes over the streams when using the [i] assignment the array length is set to i which means that if it is not i === stream.lenght + 1 then inside the loop there will be entries which are undefined. By using push the array won't add empty entries which should fix the loop.
johannes-vogel
approved these changes
May 26, 2025
Merged
johannes-vogel
added a commit
that referenced
this pull request
May 28, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 2.0.1</summary> ## [2.0.1](db-service-v2.0.0...db-service-v2.0.1) (2025-05-27) ### Fixed * **`search`:** do not search on non-projected elements ([#1198](#1198)) ([73d9e67](73d9e67)) * add shortcut for empty UPDATE.data ([#1203](#1203)) ([cf991ff](cf991ff)) * hierarchies in quoted mode ([3465cba](3465cba)) * only sort by locale if locale is set ([#1193](#1193)) ([3465cba](3465cba)) ### Changed * remove stream_compat ([#1139](#1139)) ([#1144](#1144)) ([1b8b2d9](1b8b2d9)) </details> <details><summary>sqlite: 2.0.1</summary> ## [2.0.1](sqlite-v2.0.0...sqlite-v2.0.1) (2025-05-27) ### Changed * remove stream_compat ([#1139](#1139)) ([#1144](#1144)) ([1b8b2d9](1b8b2d9)) </details> <details><summary>postgres: 2.0.1</summary> ## [2.0.1](postgres-v2.0.0...postgres-v2.0.1) (2025-05-27) ### Fixed * Enable mixing stream and normal parameters in queries ([#1179](#1179)) ([7ee8083](7ee8083)) * hierarchies in quoted mode ([3465cba](3465cba)) * only sort by locale if locale is set ([#1193](#1193)) ([3465cba](3465cba)) ### Changed * remove PG `?` placeholder replacement ([#1180](#1180)) ([a1e0bd9](a1e0bd9)) * remove stream_compat ([#1139](#1139)) ([#1144](#1144)) ([1b8b2d9](1b8b2d9)) </details> <details><summary>hana: 2.0.1</summary> ## [2.0.1](hana-v2.0.0...hana-v2.0.1) (2025-05-27) ### Added * set NOW as session var in addition to $now ([#1201](#1201)) ([33d4814](33d4814)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: D045778 <johannes.vogel@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1168