Skip to content

fix: reject nested projection if duplicated #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patricebender merged 6 commits into from
Nov 26, 2025
Merged

fix: reject nested projection if duplicated #1411

patricebender merged 6 commits into from
Nov 26, 2025

Conversation

@patricebender
Copy link
Member

@patricebender patricebender commented Nov 10, 2025

fix #1408

patricebender
patricebender commented Nov 24, 2025
View reviewed changes
Copy link
Member Author

@patricebender patricebender left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test which shows a potential fix with as foo

await cds.ql`SELECT from ${Books} { author {name}, author as foo {ID as name }}`

@johannes-vogel johannes-vogel added the next release pr to be checked for next release label Nov 24, 2025
@patricebender patricebender enabled auto-merge (squash) November 26, 2025 10:12
@patricebender patricebender merged commit 6e924c9 into main Nov 26, 2025
6 of 7 checks passed
@patricebender patricebender deleted the patrice/duplicate branch November 26, 2025 10:19
@cap-bots cap-bots mentioned this pull request Nov 26, 2025
Merged
johannes-vogel pushed a commit that referenced this pull request Nov 26, 2025
@cap-bots
chore: release main (#1403)
f9d6ece 
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 2.7.0</summary>

##
[2.7.0](db-service-v2.6.0...db-service-v2.7.0)
(2025-11-26)


### Added

* `error` standard function
([#1421](#1421))
([b1b0fca](b1b0fca))


### Fixed

* LimitedRank with compositions
([#1391](#1391))
([31766cd](31766cd))
* reject nested projection if duplicated
([#1411](#1411))
([6e924c9](6e924c9))
</details>

<details><summary>hana: 2.4.0</summary>

##
[2.4.0](hana-v2.3.4...hana-v2.4.0)
(2025-11-26)


### Added

* `error` standard function
([#1421](#1421))
([b1b0fca](b1b0fca))
* show default pool configuration in `env`
([#1422](#1422))
([89b397a](89b397a))


### Fixed

* **deps:** update dependency hdb to v2
([#1266](#1266))
([742a784](742a784))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @cap-js/db-service bumped from ^2.6.0 to ^2.7.0
</details>

<details><summary>postgres: 2.1.0</summary>

##
[2.1.0](postgres-v2.0.6...postgres-v2.1.0)
(2025-11-26)


### Added

* show default pool configuration in `env`
([#1422](#1422))
([89b397a](89b397a))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @cap-js/db-service bumped from ^2.6.0 to ^2.7.0
</details>

<details><summary>sqlite: 2.1.0</summary>

##
[2.1.0](sqlite-v2.0.4...sqlite-v2.1.0)
(2025-11-26)


### Added

* show default pool configuration in `env`
([#1422](#1422))
([89b397a](89b397a))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @cap-js/db-service bumped from ^2.6.0 to ^2.7.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@johannes-vogel johannes-vogel mentioned this pull request Nov 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stewsk stewsk stewsk approved these changes

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@BobdenOs BobdenOs Awaiting requested review from BobdenOs BobdenOs is a code owner

@sjvans sjvans Awaiting requested review from sjvans sjvans is a code owner

@David-Kunz David-Kunz Awaiting requested review from David-Kunz David-Kunz is a code owner

Assignees

No one assigned

Labels

next release pr to be checked for next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

missing error for duplicated nested projection

4 participants

@patricebender @stewsk @johannes-vogel