fix: GraphiQL Explorer Plugin init function usage #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjvans
requested changes
Jul 12, 2023
Contributor
sjvans
left a comment
sjvans
left a comment
There was a problem hiding this comment.
we should either pin version or support several thereof, no?
Member
Author
|
Yes, we should probably pin the version. However, that would mean that we manually need to check for und update to new versions. At least I am not aware of any tools that automatically check for new versions from CDN URLs. |
Contributor
then let's take as bli |
sjvans
approved these changes
Jul 12, 2023
johannes-vogel
pushed a commit
that referenced
this pull request
Jul 12, 2023
johannes-vogel
added a commit
that referenced
this pull request
Sep 4, 2023
* chore: prepare next release (#104) * fix: GraphiQL Explorer Plugin init function usage (#106) * chore: pin `graphiql` and `@graphiql/plugin-explorer` versions (#107) * Pin `graphiql` and `@graphiql/plugin-explorer` * Add changelog entry * Reword changelog entry * prepare 0.6.2 hotfix (#108) * Prepare changelog for 0.6.2 * Prepare package.json for 0.6.2 * add license folder again * chore: prepare next release (#111) * docs: swap annotate and `cds w` steps in README (#112) * Using axios 1 * feat: don't log empty `variables` object (#113) * Don't log empty variables object * Add changelog entry * Simplify `queryInfo` object creation * Simplify object creation further * Improve comment * add changelog (#115) --------- Co-authored-by: Marcel Schwarz <marcel.schwarz@sap.com> Co-authored-by: Christian Neu <67069868+christianneu@users.noreply.github.com> Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation pattern of the GraphiQL Explorer Plugin changed upstream causing the initialization to need to be adjusted.
See: https://github.com/graphql/graphiql/releases/tag/%40graphiql%2Fplugin-explorer%400.3.0