chore: Lint#153
Merged
Merged
Conversation
daogrady
commented
Jun 2, 2026
daogrady
commented
Jun 2, 2026
daogrady
commented
Jun 2, 2026
tim-sh
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a multitude of lint warnings in the current code. This PR addresses most of them.
The only remaining warnings should come from the
complexityrule, for which we currently have 11 violations. The most complex function has a whopping complexity of 84 (getSchema)! I am not sure if that means that we should rework the offending functions, or if we should instead remove this rule from the rule set.