Skip to content

Conversation

@MariusPerleSAP
Copy link
Contributor

There are many more attributes for ORD packages that currently can't be set with .cdsrc and custom.ord.json files.

This change allows passing all values to packages array.

@MariusPerleSAP
Copy link
Contributor Author

Currently:
no sanitation and no checks --> high performance but usage issue might occur

@zongqichen zongqichen linked an issue Sep 2, 2025 that may be closed by this pull request
@MariusPerleSAP MariusPerleSAP changed the title allow loading of additional attributes for packages feat: allow loading of additional attributes for packages Sep 2, 2025
Co-authored-by: Zongqi Chen <137198879+zongqichen@users.noreply.github.com>
Copy link
Contributor

@zongqichen zongqichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zongqichen zongqichen merged commit 07915da into main Sep 2, 2025
4 checks passed
@zongqichen zongqichen deleted the add_package_level_attributes branch September 2, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Industry, lineOfBusiness, and countries at the package level

3 participants