Skip to content

Fix for read attachment#147

Merged
yashmeet29 merged 2 commits intodevelopfrom
FixReadAttachmentIssue
Jul 8, 2025
Merged

Fix for read attachment#147
yashmeet29 merged 2 commits intodevelopfrom
FixReadAttachmentIssue

Conversation

@yashmeet29
Copy link
Copy Markdown
Member

Describe your changes

This PR fixes the ReadAttachment issue that was there with latest cds update. Till now we returned content buffer after reading the it from SDM. This buffer was further processed by CDS library to display the attachment. However with recent releases they stopped processing content buffer and expected content to be instance of Readable. This was the reason ReadAttachments was failing. With this PR we now return content which is instance of Readable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description
Screenshot 2025-07-02 at 7 01 04 PM

@yashmeet29 yashmeet29 changed the title Fix for read attachment, UTs & Integration tests Fix for read attachment Jul 2, 2025
@yashmeet29 yashmeet29 merged commit 10cbe51 into develop Jul 8, 2025
8 checks passed
@yashmeet29 yashmeet29 deleted the FixReadAttachmentIssue branch July 8, 2025 06:02
Juergen-Goebl-msggroup pushed a commit to Andreas-Meindl-msggroup/sdm that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants