Merged
Conversation
rashmiangadi11
approved these changes
Jul 3, 2025
Juergen-Goebl-msggroup
pushed a commit
to Andreas-Meindl-msggroup/sdm
that referenced
this pull request
Apr 14, 2026
Fix for read attachment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes the ReadAttachment issue that was there with latest cds update. Till now we returned content buffer after reading the it from SDM. This buffer was further processed by CDS library to display the attachment. However with recent releases they stopped processing content buffer and expected content to be instance of Readable. This was the reason ReadAttachments was failing. With this PR we now return content which is instance of Readable.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested