Skip to content

Implement token handling and SDM API requests using Cloud SDK#228

Merged
rashmiangadi11 merged 26 commits intodevelopfrom
SDMEXT-852
Feb 3, 2026
Merged

Implement token handling and SDM API requests using Cloud SDK#228
rashmiangadi11 merged 26 commits intodevelopfrom
SDMEXT-852

Conversation

@rashmiangadi11
Copy link
Copy Markdown

@rashmiangadi11 rashmiangadi11 commented Jan 22, 2026

Describe your changes

Standardize token handling and outbound HTTP calls via SAP Cloud SDK. Support user-propagation and technical-user flows, unify REST client usage with resilience, observability, and security best practices. Deliver reusable modules, destination configuration, tests, and documentation.

Any documentation

-This PR creates 2 methods getDestination which returns user token related destination and getTechnicalDestination which returns the technical credentials destination and these destinations are passed to different methods and no need of token as destination has it within even the subdomain.
Removed all the unused token generation code and also updated the unit tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description

Single tenant
Screenshot 2026-01-23 at 2 02 29 PM

Multitenant

https://github.com/cap-js/sdm/actions/runs/21509535685/job/61972940377
Screenshot 2026-01-30 at 2 08 47 PM

Comment thread lib/sdm.js Fixed
Comment thread test/lib/util/index.test.js Fixed
Comment thread test/lib/sdm.test.js Fixed
Comment thread test/lib/sdm.test.js Fixed
Comment thread test/lib/sdm.test.js Fixed
Comment thread test/lib/sdm.test.js Fixed
Comment thread test/lib/sdm.test.js Fixed
Comment thread lib/sdm.js Fixed
Comment thread lib/sdm.js Fixed
Comment thread test/lib/sdm.test.js Fixed
Comment thread test/lib/sdm.test.js Fixed
@yashmeet29
Copy link
Copy Markdown
Member

yashmeet29 commented Jan 23, 2026

@rashmiangadi11, please attach the link of Integration-tests run

Comment thread test/lib/mtx/server.test.js Fixed
Comment thread lib/sdm.js Fixed
Comment thread lib/sdm.js Fixed
@rashmiangadi11 rashmiangadi11 merged commit 84e2875 into develop Feb 3, 2026
9 checks passed
@rashmiangadi11 rashmiangadi11 deleted the SDMEXT-852 branch February 3, 2026 07:24
Juergen-Goebl-msggroup pushed a commit to Andreas-Meindl-msggroup/sdm that referenced this pull request Apr 14, 2026
Implement token handling and SDM API requests using Cloud SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants