Skip to content

Sonar fixes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Sonar fixes #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96700a8
Sonar fixes
yashmeet29 Jun 19, 2024
7354e8a
Merge branch 'develop' into FixSonarIssues
vibhutikumar07 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/handler/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,7 @@ async function createAttachment(
const response = await updateServerRequest(
documentCreateURL,
formData,
config,
attachments,
data.ID
config
);
return response;
}
Expand Down
1 change: 0 additions & 1 deletion lib/sdm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,5 @@ module.exports = class SDMAttachmentsService extends (
entity,
this.deleteAttachmentsWithKeys.bind(this)
);
return;
}
};
4 changes: 2 additions & 2 deletions lib/util/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ async function generateSDMBearerToken(credentials, jwt) {
});
}
function isTokenExpired(exp) {
var expiry = new Date(exp * 1000);
var now = new Date();
const expiry = new Date(exp * 1000);
const now = new Date();
return now > expiry;
}
function decodeAccessToken(jwtEncoded) {
Expand Down