Skip to content

feat: custom resource attributes#394

Merged
sjvans merged 8 commits intomainfrom
custom-resource-attributes
Nov 13, 2025
Merged

feat: custom resource attributes#394
sjvans merged 8 commits intomainfrom
custom-resource-attributes

Conversation

@sjvans
Copy link
Copy Markdown
Contributor

@sjvans sjvans commented Nov 13, 2025

No description provided.

@sjvans sjvans force-pushed the custom-resource-attributes branch from 9ea2f5f to 81bbc5d Compare November 13, 2025 09:54
@sjvans sjvans requested a review from PDT42 November 13, 2025 10:35
@sjvans sjvans marked this pull request as ready for review November 13, 2025 10:35
Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@PDT42 PDT42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be used to manually override e.g. sap.cf.app_id - but I might be hallucinating and I am not at all certain that it would gain a malicious user anything ...

EDIT: Guess I am not hallucinating at least, since IT'S IN THE DOCS 😮‍💨

@sjvans
Copy link
Copy Markdown
Contributor Author

sjvans commented Nov 13, 2025

I am not at all certain that it would gain a malicious user anything ...

anybody with credentials to the telemetry backend can send any data, so no worse through this pr

@sjvans sjvans merged commit ae3e619 into main Nov 13, 2025
13 checks passed
@sjvans sjvans deleted the custom-resource-attributes branch November 13, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants