Conversation
…when keyboard is visible
robingenz
added
platform: android
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Android edge-to-edge support plugin to avoid applying a bottom margin when the on-screen keyboard (IME) is visible (preventing double-counting), and updates the example app to include the Capacitor Keyboard plugin configuration needed to reproduce/validate the behavior.
Changes:
- Refactors inset handling into a shared
applyInsetsInternal(...)helper inEdgeToEdge.java. - Changes bottom margin application logic when the IME is visible to avoid double-counting.
- Adds
@capacitor/keyboardto the example app and wires the Android + Capacitor config for it.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/android-edge-to-edge-support/android/src/main/java/io/capawesome/capacitorjs/plugins/androidedgetoedgesupport/EdgeToEdge.java | Refactors inset application and adjusts bottom margin behavior during IME visibility. |
| packages/android-edge-to-edge-support/example/package.json | Adds @capacitor/keyboard dependency. |
| packages/android-edge-to-edge-support/example/package-lock.json | Locks @capacitor/keyboard and updates resolved dependency tree. |
| packages/android-edge-to-edge-support/example/capacitor.config.json | Configures Keyboard plugin (resizeOnFullScreen: false). |
| packages/android-edge-to-edge-support/example/android/capacitor.settings.gradle | Includes the Android module for @capacitor/keyboard. |
| packages/android-edge-to-edge-support/example/android/app/capacitor.build.gradle | Adds Gradle dependency for capacitor-keyboard. |
| .changeset/sad-keys-play.md | Adds a patch changeset describing the fix. |
Files not reviewed (1)
- packages/android-edge-to-edge-support/example/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...oid/src/main/java/io/capawesome/capacitorjs/plugins/androidedgetoedgesupport/EdgeToEdge.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
applyInsetsInternalmethod0when the keyboard is shown (the system already resizes the window)@capacitor/keyboardplugin to the example app withresizeOnFullScreen: falseClose #812