225 add user attributes store#229
Merged
Merged
Conversation
…json files specified in the pulumi config or file imported during deployment
mehalter
previously approved these changes
Jun 4, 2025
Member
mehalter
left a comment
mehalter
left a comment
There was a problem hiding this comment.
Looks good to me! Just needs the one pyright thing fixed, seems like just a check for None and then a couple typos that seem valid
mehalter
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO TEST
NOTE: This has been deployed both with and without the users/groups specified in the untracked assets files so we could test it worked both ways. The untracked users/groups have been removed, but the attributes specified in the cape.admin untracked attributes remain.
cape.admin. All users should exist however (just with empty attr records other than the user id)