Skip to content

fixed bad parental relations#27

Merged
thecaffiend merged 3 commits into
mainfrom
9-fix-bad-parental-relations
Jun 18, 2024
Merged

fixed bad parental relations#27
thecaffiend merged 3 commits into
mainfrom
9-fix-bad-parental-relations

Conversation

@thecaffiend
Copy link
Copy Markdown
Member

@thecaffiend thecaffiend commented Jun 18, 2024

TO TEST

  • grab this branch
  • destroy anything currently deployed to aws (you can do it without, but you'r on your own to find the correct new resource hierarchy when previewing. it may just work right)
  • pulumi preview with this branch
  • compare the hierarchy that is displayed to the previous resource hierarchy (see attachment below). note the previous one has a bunch of resources with the stack as a parent where they should belong to other resources instead)
  • make sure the new hierarchy seems logically correct (the only top level children of the stack should be the meta, datalakehouse, and our custom classifier.

pulumi-up-bad-parents.md

@thecaffiend thecaffiend linked an issue Jun 18, 2024 that may be closed by this pull request
@mehalter
Copy link
Copy Markdown
Member

Did you mean to assign this to me or simply request a review?

Copy link
Copy Markdown
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! :shipit:

@thecaffiend thecaffiend merged commit 67c5144 into main Jun 18, 2024
@thecaffiend thecaffiend deleted the 9-fix-bad-parental-relations branch June 18, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix bad parental relations

2 participants