Skip to content

added a config value for type of deployment#91

Merged
mehalter merged 2 commits into
mainfrom
66-get-a-config-value-for-type-of-deployment
Sep 4, 2024
Merged

added a config value for type of deployment#91
mehalter merged 2 commits into
mainfrom
66-get-a-config-value-for-type-of-deployment

Conversation

@thecaffiend
Copy link
Copy Markdown
Member

NOTE: This all assumes that

  • the current state of the deployed system has a DAP API and that it is in a "dev" stage (which it most likely is set up as).
  • you are logged into the aws account already

TO TEST

  • check out this branch
  • attempt a pulumi preview with everything as-is. you should see no changes in the DAP API stage resources
  • modify the dev config file to change the stage-name in deployment:meta to some other value (e.g. devdev)
  • again try pulumi preview. you should now see that it wants to replace the existing stage with a new one.
  • revert all changes in the local repo. you are done.

@thecaffiend thecaffiend linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Copy Markdown
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is getting revamped after #91 , we could hold off on merging this until the configuration changes are implemented and this would get cleaned up quite a bit

Comment thread capeinfra/swimlanes/private.py Outdated
@mehalter mehalter force-pushed the 66-get-a-config-value-for-type-of-deployment branch from 37fa11a to 530adb2 Compare September 4, 2024 16:03
@mehalter
Copy link
Copy Markdown
Member

mehalter commented Sep 4, 2024

Resolved this off of the new #91 . Once that PR is merged in, this is ready to go. Moved to draft to avoid accidental merging until other PR is done

@mehalter mehalter marked this pull request as draft September 4, 2024 16:04
@mehalter mehalter force-pushed the 66-get-a-config-value-for-type-of-deployment branch from 530adb2 to 5f2bc7d Compare September 4, 2024 16:11
@mehalter mehalter marked this pull request as ready for review September 4, 2024 16:26
@mehalter mehalter force-pushed the 66-get-a-config-value-for-type-of-deployment branch from 5f2bc7d to 409757e Compare September 4, 2024 16:27
@mehalter mehalter merged commit ecb6d07 into main Sep 4, 2024
@mehalter mehalter deleted the 66-get-a-config-value-for-type-of-deployment branch September 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get a config value for type of deployment

2 participants