Skip to content

87 need to pass region into lambdas that need it as an env var#93

Merged
edpg-cp-24 merged 11 commits into
mainfrom
87-need-to-pass-region-into-lambdas-that-need-it-as-an-env-var
Aug 29, 2024
Merged

87 need to pass region into lambdas that need it as an env var#93
edpg-cp-24 merged 11 commits into
mainfrom
87-need-to-pass-region-into-lambdas-that-need-it-as-an-env-var

Conversation

@edpg-cp-24
Copy link
Copy Markdown
Contributor

@edpg-cp-24 edpg-cp-24 commented Aug 28, 2024

I have not / cannot test this because I cannot deploy.

TO TEST

  • checkout/deploy this branch
  • verify that lambda new_s3obj_queue_notifier_lambda.py still works
    • put a new object into a raw bucket and ensure that etl functions as expected
  • verify that lambda sqs_dap_submit_lambda.py still works
    • make sure rest api endpoint still functions as expected

@edpg-cp-24 edpg-cp-24 linked an issue Aug 28, 2024 that may be closed by this pull request
need to pass region into lambdas that need it as an env var #87
Closed
thecaffiend
thecaffiend requested changes Aug 29, 2024
View reviewed changes
Comment thread assets/lambda/new_s3obj_queue_notifier_lambda.py Outdated
thecaffiend
thecaffiend requested changes Aug 29, 2024
View reviewed changes
Comment thread capeinfra/datalake/datalake.py Outdated
@edpg-cp-24 edpg-cp-24 merged commit af71154 into main Aug 29, 2024
@edpg-cp-24 edpg-cp-24 deleted the 87-need-to-pass-region-into-lambdas-that-need-it-as-an-env-var branch August 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thecaffiend thecaffiend thecaffiend approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

need to pass region into lambdas that need it as an env var

2 participants

@edpg-cp-24 @thecaffiend