it = it.skip breaks with mocha#35
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
chgeo
reviewed
Apr 28, 2026
|
|
||
| // Fetch API disallows GET|HEAD requests with body | ||
| if (axios.constructor.name === 'Naxios') it = it.skip | ||
| if (axios.constructor.name === 'Naxios') { |
Contributor
There was a problem hiding this comment.
This detection looks brittle. Could e.g. do it by checking for a native axios API.
danjoa
approved these changes
May 5, 2026
Member
danjoa
left a comment
danjoa
left a comment
There was a problem hiding this comment.
Confirmed the behavior on mocha → addressed it even simpler, which avoids any assumptions on internal implementations of it and it.skip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
during
npx mocha --parallel bookstore/test,it = it.skipsomehow leads to the test file being loaded again and loop only breaks becauseitis then undefined...