Skip to content

Conversation

@bugwelle
Copy link
Contributor

@bugwelle bugwelle commented May 4, 2023

It seems some URLs were missing. See screenshot below.
Also note that the annotation @Common.FieldControl is not mentioned anywhere else. Is something missing here?

Screenshot 2023-05-04 at 12 25 06

@bugwelle bugwelle requested a review from chgeo May 4, 2023 10:26
Copy link
Contributor

@chgeo chgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. In the old repo, these links were probably in the central links.md file that was included everywhere. We no longer support this here.

@chgeo chgeo merged commit 4fe95cb into main May 4, 2023
@chgeo chgeo deleted the guide-urls branch May 4, 2023 10:59
@bugwelle
Copy link
Contributor Author

bugwelle commented May 4, 2023

@chgeo I think it would be worth to grep for see [ in the rendered HTML. There are a few other places where a link is still missing. :-)

@chgeo
Copy link
Contributor

chgeo commented May 4, 2023

Good point. Will do.

@chgeo
Copy link
Contributor

chgeo commented May 4, 2023

Fixed

@bugwelle
Copy link
Contributor Author

bugwelle commented May 4, 2023

Thanks!

For reference: 1df40e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants