req.user vs req.user #1493
Merged
req.user vs req.user #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ::: tip | ||
| Please note the difference between `req` in a service handler (instance of `cds.EventContext`) and `req` in an express middleware (instance of `http.IncomingMessage`). | ||
| Case in point, `req.user` in a service handler is an official API and, if not explicitely set, points to `cds.context.user`. | ||
| On the other hand, setting `req.user` in a custom authentication middleware is deprecated. |
There was a problem hiding this comment.
do you generally discourage the use use of req.user in middleware or only for setting properties?
Contributor
There was a problem hiding this comment.
We do recommend the usage of <cds.Request>.user or cds.context.user.
Our authentication middlewares only set cds.context.user which later on is also used when constructing a cds.Request.
<express.Request>.user is not set by us but if custom authentication middlewares set it, it's still working but deprecated. Custom authentication middlewares should also set cds.context.user instead.
smahati
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
danjoa
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #1483