Conversation
GA-023: Fix docs/README version drift - Update version references from v1.0.2/v2.2.0 to v2.6.0 - Fix install command to use /v2 module path - Fix import paths in docs to include /v2 - Update Go prerequisite from 1.21+ to 1.25+ GA-024: Unregister stub gRPC services - Remove RegistryService and RevocationService from gRPC registration - Both are TODO-only stubs; registering them is misleading - Services retained in codebase for future implementation GA-025: Add timeout to CLI validate URL fetch - Replace http.Get with http.Client using configurable --timeout flag - Add context.WithTimeout for cancellation support - Check HTTP status code before reading body
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
GA remediation hardening for CapiscIO Core by aligning docs with the current v2 module/version, removing misleading stub gRPC service registrations, and making the CLI validate command’s URL fetch safer via timeouts/status checks.
Changes:
- Update docs/README version references to v2.6.0 and correct install/module/import path guidance for
/v2. - Stop registering stub-only
RegistryServiceandRevocationServicein the gRPC server. - Add
--timeout,context.WithTimeout, and HTTP status checking forcapiscio validatewhen fetching an Agent Card from a URL.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| internal/rpc/server.go | Removes registration of stub-only gRPC services (Registry/Revocation) to avoid misleading “success” behavior. |
| cmd/capiscio/validate.go | Replaces http.Get with request+client timeout handling and checks HTTP status before reading the body. |
| docs/index.md | Updates release/version/install and import path examples to the /v2 module path and Go 1.25+. |
| README.md | Updates release/version and install command to use the /v2 module path. |
- Use Cobra command context as parent for timeout (respects SIGINT) - Limit URL response body to 10MB to prevent memory exhaustion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GA Remediation — Core Hardening (T1)
GA-023: Fix docs/README version drift
/v2module path/v2GA-024: Unregister stub gRPC services
GA-025: Add timeout to CLI validate URL fetch
http.Getwithhttp.Clientusing configurable--timeoutflagcontext.WithTimeoutfor cancellation supportTests pass:
go test ./internal/rpc/ ./cmd/capiscio/✅