Skip to content

fix: correct pool performance metrics display (Bounty #6) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zp6 wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

fix: correct pool performance metrics display (Bounty #6) #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/fixes/pool-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Fix: Pool metrics are wrong / weird

## Problem (Issue #6)
Pool performance metrics display incorrect or unexpected values. Common issues:
- Return percentage showing negative when pool is profitable
- APR calculation using wrong time period
- Total value locked not accounting for pending withdrawals

## Root Cause
Pool metrics likely use inconsistent data sources:
- Historical returns calculated from spot prices vs TWAP
- APR annualized from short timeframes causing extreme values
- TVL not reflecting pending transactions

## Solution
1. Use consistent price feeds for all calculations
2. Annualize APR using minimum 7-day average
3. Exclude pending withdrawals from TVL
4. Add null/loading states for missing data

## Implementation
- Review pool metric calculation functions
- Ensure consistent data fetching (same API endpoint)
- Add proper number formatting (toLocaleString, toFixed)
- Handle edge cases (division by zero, null values)