fix: guard pool metrics against NaN/Infinity/undefined values (fixes #6)#240
Open
jiangyj545 wants to merge 1 commit into
Open
fix: guard pool metrics against NaN/Infinity/undefined values (fixes #6)#240jiangyj545 wants to merge 1 commit into
jiangyj545 wants to merge 1 commit into
Conversation
…apofficial#6) - Fee APY: return null instead of dividing by zero when pool balance is 0 or empty - Add safeMetric() helper to gracefully handle NaN, Infinity, null, undefined - % of Pool column: use safeMetric to prevent Infinity display - Shows '-' for invalid metrics instead of nonsensical numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pool performance metrics display incorrect or nonsensical numbers (Infinity, NaN, or extremely large values) when pool balances are zero, empty, or not yet loaded.
Root Cause
Three issues in
src/components/pool/Pools.svelte:Fee APY calculation divides by pool balance without zero-guard:
% of Pool column divides stake by balance without safety check — same Infinity problem.
formatForDisplay()does not handleInfinity(only catchesNaNviaisNaN()), soInfinitypasses through and renders as garbage.Fix
nullwhen pool balance is ≤ 0 or falsy, instead of dividing by zerosafeMetric()helper: Catchesnull,undefined,NaN, andInfinityin one place, returns"-"fallbacksafeMetric()— shows"-"when balance is unavailable, otherwiseX%safeMetric()for the division result (existing zero-check kept as first guard)Changes
src/components/pool/Pools.svelteBuild
npx rollup -c✅ (no new warnings; circular deps are pre-existing)